Open
Conversation
|
Might be good to add validation for the hard unit distance in the creator UI so it's not possible to set the interact distance greater than the specified hard limit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: Optimize Doorlock Nearby Door Processing
Description
This PR optimizes the door processing loop in
ox_doorlockto improve performance for scenarios with many nearby doors.Changes Made
ClosestDoorcalculation/UI thread into a single thread to eliminate shared state issues and reduce thread overhead.GetAspectRatio(true)calculation to the drawing thread, as it’s only needed when rendering sprites.nearbyDoorsandnearbyDoorsCount, computing values locally to simplify state management.Related Issues
Testing
ClosestDoorselection matches previous behavior (closest door withinmaxDistanceis correctly identified).Performance Impact
Screenshots/Video
BEFORE:
https://github.com/user-attachments/assets/4dbda7a0-9c15-442e-923b-05fedf8a467a
AFTER:
https://github.com/user-attachments/assets/54cecbe6-ce8a-4582-b308-24106c65d086
Additional Notes